Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Git to include prefetch logic #246

Merged
merged 4 commits into from
Dec 17, 2019
Merged

Update Git to include prefetch logic #246

merged 4 commits into from
Dec 17, 2019

Conversation

derrickstolee
Copy link
Contributor

@derrickstolee derrickstolee commented Nov 20, 2019 •
edited
Loading

See microsoft/git#223 for details.

Resolves #141.

  • Call git gvfs-helper prefetch in scalar maintenance fetch-commits-and-trees
  • Delete existing prefetch logic in the C# layer.

@derrickstolee
Copy link
Contributor Author

/azp run microsoft.scalar

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@derrickstolee derrickstolee marked this pull request as ready for review December 16, 2019 19:46
@derrickstolee derrickstolee changed the title [WIP] [PR Build] Update Git to include prefetch logic [PR Build] Update Git to include prefetch logic Dec 16, 2019
@derrickstolee derrickstolee reopened this Dec 17, 2019
jeffhostetler
jeffhostetler approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@jeffhostetler jeffhostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Lots of pink dead code.

@derrickstolee
Update Git to include prefetch logic
e333bca 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee
GitProcess: use gvfs-helper for prefetch
255b0e5 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee
Delete prefetch tests for removed functionality
e8f0a0f 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee
Delete unused code
47b898d 
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee changed the title [PR Build] Update Git to include prefetch logic Update Git to include prefetch logic Dec 17, 2019
@derrickstolee derrickstolee merged commit 0771036 into microsoft:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhostetler jeffhostetler jeffhostetler approved these changes

@jrbriggs jrbriggs Awaiting requested review from jrbriggs

@garimasi514 garimasi514 Awaiting requested review from garimasi514

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefetch should run as part of git fetch and git pull
2 participants
@derrickstolee @jeffhostetler